Update SpacemanDMM suite to 1.11#592
Closed
Absolucy wants to merge 12 commits into
Closed
Conversation
Absolucy
commented
Feb 25, 2026
| complexity = 3 | ||
|
|
||
| /obj/item/mod/module/power_kick/on_throw_impact(mob/living/source, obj/target, datum/thrownthing/thrownthing) | ||
| SIGNAL_HANDLER |
Contributor
Author
There was a problem hiding this comment.
this was unneeded, as the original on_throw_impact has SIGNAL_HANDLER, which SDMM will still use even if we override the whole proc.
| return ..() | ||
|
|
||
| /obj/item/clothing/gloves/radio/advanced/handle_speech(datum/source, list/speech_args) | ||
| SIGNAL_HANDLER |
Contributor
Author
There was a problem hiding this comment.
original handle_speech has SIGNAL_HANDLER so this is unneeded
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…nt is now no longer required
Collaborator
|
Applied some comments, and noticed that during the obj to atoms pr that random signal handler was removed... meaning the comment block that removed it was no longer required. |
Collaborator
|
god damn it i didnt even notice that the proc was duplicated because the cherrypick added it in... bleh |
Updated SPACEMAN_DMM_VERSION for pentest.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Collaborator
|
Merge attempt # 2... I am so going to murder whatever keeps failing these tests.... |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Updates
SPACEMAN_DMM_VERSIONtosuite-1.11independencies.sh, for the https://github.com/SpaceManiac/SpacemanDMM/releases/tag/suite-1.11 releasebasically a 1-line port of tgstation/tgstation#92811
also fixed some linter errors that were popping up with the latest sdmm
Why It's Good For The Game
So 516 things like alists,
load_ext,for(k,v), etc can be used without failing linters - which i noticed occurring on #543, for exampleChangelog
No player-facing changes